Bump react-dom to 19.2.8 to match react - #3231
Closed
adamw wants to merge 1 commit into
Closed
Conversation
react was bumped to 19.2.8 in #3221 without react-dom, leaving the two packages at different versions. React refuses to start when they differ, so every UI test failed and master has been red since then.
Member
Author
|
Superseded by #3245, which made the same react-dom 19.2.7 → 19.2.8 bump. Master is fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the red
verifycheck on master and on every open PR.#3221 bumped
react19.2.7 → 19.2.8 but leftreact-domat 19.2.7. React refuses to initialise when the two differ:All 16 vitest suites fail on import, so master has been red since #3221 merged (its own
verifycheck was already failing at merge time).Verified locally under Node 24 (the version CI uses): 16 test files, 34 tests, all passing.